create and open file in one step rather than two

cryostatio · Oct 29, 2021 · 3cd1f37 · 3cd1f37
1 parent 321d422
commit 3cd1f37
Showing 1 changed file with 22 additions and 39 deletions.
diff --git a/src/main/java/io/cryostat/net/web/http/api/beta/RecordingsPostHandler.java b/src/main/java/io/cryostat/net/web/http/api/beta/RecordingsPostHandler.java
@@ -192,49 +192,32 @@ public void handle(RoutingContext ctx) {
                                 });
         ctx.vertx()
                 .fileSystem()
-                .createFile(
+                .open(
                         destinationFile,
-                        createFile -> {
-                            if (createFile.failed()) {
-                                ctx.fail(new HttpStatusException(500, createFile.cause()));
+                        new OpenOptions().setAppend(true).setCreateNew(true),
+                        openFile -> {
+                            if (openFile.failed()) {
+                                ctx.fail(new HttpStatusException(500, openFile.cause()));
                                 return;
                             }
-                            ctx.vertx()
-                                    .fileSystem()
-                                    .open(
-                                            destinationFile,
-                                            new OpenOptions().setAppend(true),
-                                            openFile -> {
-                                                if (openFile.failed()) {
-                                                    ctx.fail(
-                                                            new HttpStatusException(
-                                                                    500, openFile.cause()));
-                                                    return;
-                                                }
-                                                ctx.request()
-                                                        .handler(
-                                                                buffer -> {
-                                                                    lastReadTimestamp.set(
-                                                                            System.nanoTime());
-                                                                    openFile.result().write(buffer);
-                                                                })
-                                                        .exceptionHandler(
-                                                                fileUploadPath
-                                                                        ::completeExceptionally)
-                                                        .endHandler(
-                                                                v -> {
-                                                                    ctx.vertx()
-                                                                            .cancelTimer(timerId);
-                                                                    openFile.result().close();
-                                                                    fileUploadPath.complete(
-                                                                            destinationFile);
-                                                                });
-                                                ctx.addEndHandler(
-                                                        ar -> {
-                                                            ctx.vertx().cancelTimer(timerId);
-                                                        });
-                                                ctx.request().resume();
+                            ctx.request()
+                                    .handler(
+                                            buffer -> {
+                                                lastReadTimestamp.set(System.nanoTime());
+                                                openFile.result().write(buffer);
+                                            })
+                                    .exceptionHandler(fileUploadPath::completeExceptionally)
+                                    .endHandler(
+                                            v -> {
+                                                ctx.vertx().cancelTimer(timerId);
+                                                openFile.result().close();
+                                                fileUploadPath.complete(destinationFile);
                                             });
+                            ctx.addEndHandler(
+                                    ar -> {
+                                        ctx.vertx().cancelTimer(timerId);
+                                    });
+                            ctx.request().resume();
                         });
 
         try {