-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[autorules] Credentials deletion enhancements (#516)
* Respond 404 when deleting nonexistent credentials * Retrieve Credentials from Manager on each PeriodicArchiver run If Credentials are deleted afer a rule is triggered/a PeriodicArchiver starts, the PeriodicArchiver should fail to archive from that point forward since its Credentials access has been revoked * Test credentials revocation during archiver run
- Loading branch information
1 parent
4d4cf1b
commit 5852370
Showing
9 changed files
with
207 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
163 changes: 163 additions & 0 deletions
163
src/test/java/io/cryostat/net/web/http/api/v2/TargetCredentialsDeleteHandlerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * Copyright The Cryostat Authors | ||
| * | ||
| * The Universal Permissive License (UPL), Version 1.0 | ||
| * | ||
| * Subject to the condition set forth below, permission is hereby granted to any | ||
| * person obtaining a copy of this software, associated documentation and/or data | ||
| * (collectively the "Software"), free of charge and under any and all copyright | ||
| * rights in the Software, and any and all patent rights owned or freely | ||
| * licensable by each licensor hereunder covering either (i) the unmodified | ||
| * Software as contributed to or provided by such licensor, or (ii) the Larger | ||
| * Works (as defined below), to deal in both | ||
| * | ||
| * (a) the Software, and | ||
| * (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if | ||
| * one is included with the Software (each a "Larger Work" to which the Software | ||
| * is contributed by such licensors), | ||
| * | ||
| * without restriction, including without limitation the rights to copy, create | ||
| * derivative works of, display, perform, and distribute the Software and make, | ||
| * use, sell, offer for sale, import, export, have made, and have sold the | ||
| * Software and the Larger Work(s), and to sublicense the foregoing rights on | ||
| * either these or other terms. | ||
| * | ||
| * This license is subject to the following condition: | ||
| * The above copyright notice and either this complete permission notice or at | ||
| * a minimum a reference to the UPL must be included in all copies or | ||
| * substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
| package io.cryostat.net.web.http.api.v2; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Map; | ||
|
|
||
| import io.cryostat.MainModule; | ||
| import io.cryostat.configuration.CredentialsManager; | ||
| import io.cryostat.core.log.Logger; | ||
| import io.cryostat.net.AuthManager; | ||
| import io.cryostat.net.web.http.HttpMimeType; | ||
| import io.cryostat.net.web.http.api.ApiVersion; | ||
|
|
||
| import com.google.gson.Gson; | ||
| import io.vertx.core.http.HttpMethod; | ||
| import org.hamcrest.MatcherAssert; | ||
| import org.hamcrest.Matchers; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Nested; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.Mockito; | ||
| import org.mockito.junit.jupiter.MockitoExtension; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class TargetCredentialsDeleteHandlerTest { | ||
|
|
||
| AbstractV2RequestHandler<Void> handler; | ||
| @Mock AuthManager auth; | ||
| @Mock CredentialsManager credentialsManager; | ||
| @Mock Logger logger; | ||
| Gson gson = MainModule.provideGson(logger); | ||
|
|
||
| @BeforeEach | ||
| void setup() { | ||
| this.handler = new TargetCredentialsDeleteHandler(auth, credentialsManager, gson); | ||
| } | ||
|
|
||
| @Nested | ||
| class BasicHandlerDefinition { | ||
|
|
||
| @Test | ||
| void shouldRequireAuthentication() { | ||
| Assertions.assertTrue(handler.requiresAuthentication()); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldBeV2API() { | ||
| MatcherAssert.assertThat(handler.apiVersion(), Matchers.equalTo(ApiVersion.V2)); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldHaveDELETEMethod() { | ||
| MatcherAssert.assertThat(handler.httpMethod(), Matchers.equalTo(HttpMethod.DELETE)); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldHaveTargetsPath() { | ||
| MatcherAssert.assertThat( | ||
| handler.path(), Matchers.equalTo("/api/v2/targets/:targetId/credentials")); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldHaveJsonMimeType() { | ||
| MatcherAssert.assertThat(handler.mimeType(), Matchers.equalTo(HttpMimeType.PLAINTEXT)); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldNotBeAsync() { | ||
| Assertions.assertFalse(handler.isAsync()); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldBeOrdered() { | ||
| Assertions.assertTrue(handler.isOrdered()); | ||
| } | ||
| } | ||
|
|
||
| @Nested | ||
| class RequestExecutions { | ||
| @Mock RequestParameters requestParams; | ||
|
|
||
| @Test | ||
| void shouldRespond200OnSuccess() throws Exception { | ||
| String targetId = "fooTarget"; | ||
| Mockito.when(requestParams.getPathParams()).thenReturn(Map.of("targetId", targetId)); | ||
| Mockito.when(credentialsManager.removeCredentials(Mockito.anyString())) | ||
| .thenReturn(true); | ||
|
|
||
| IntermediateResponse<Void> response = handler.handle(requestParams); | ||
|
|
||
| MatcherAssert.assertThat(response.getStatusCode(), Matchers.equalTo(200)); | ||
| Mockito.verify(credentialsManager).removeCredentials(targetId); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldRespond404OnFailure() throws Exception { | ||
| String targetId = "fooTarget"; | ||
| Mockito.when(requestParams.getPathParams()).thenReturn(Map.of("targetId", targetId)); | ||
| Mockito.when(credentialsManager.removeCredentials(Mockito.anyString())) | ||
| .thenReturn(false); | ||
|
|
||
| IntermediateResponse<Void> response = handler.handle(requestParams); | ||
|
|
||
| MatcherAssert.assertThat(response.getStatusCode(), Matchers.equalTo(404)); | ||
| Mockito.verify(credentialsManager).removeCredentials(targetId); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldWrapIOExceptions() throws Exception { | ||
| String targetId = "fooTarget"; | ||
| Mockito.when(requestParams.getPathParams()).thenReturn(Map.of("targetId", targetId)); | ||
| Mockito.when(credentialsManager.removeCredentials(Mockito.anyString())) | ||
| .thenThrow(IOException.class); | ||
|
|
||
| ApiException ex = | ||
| Assertions.assertThrows( | ||
| ApiException.class, () -> handler.handle(requestParams)); | ||
|
|
||
| MatcherAssert.assertThat(ex.getStatusCode(), Matchers.equalTo(500)); | ||
| MatcherAssert.assertThat(ex.getCause(), Matchers.instanceOf(IOException.class)); | ||
| Mockito.verify(credentialsManager).removeCredentials(targetId); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters