Skip to content

Commit

Permalink
build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.8.0…
Browse files Browse the repository at this point in the history
… to 4.8.5 (#1920)

* build(deps): bump com.github.spotbugs:spotbugs-maven-plugin

Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.3.6 to 4.8.5.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.3.6...spotbugs-maven-plugin-4.8.5.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump com.github.spotbugs:spotbugs-annotations

Bumps [com.github.spotbugs:spotbugs-annotations](https://github.com/spotbugs/spotbugs) from 4.8.0 to 4.8.5.
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](spotbugs/spotbugs@4.8.0...4.8.5)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-annotations
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* avoid finalizer throws warnings

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Azores <aazores@redhat.com>
  • Loading branch information
dependabot[bot] and andrewazores authored May 6, 2024
1 parent b2e0c30 commit 67a9745
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@
<com.h2database.h2.version>2.1.214</com.h2database.h2.version>
<org.postgresql.postgresql.version>42.7.2</org.postgresql.postgresql.version>

<com.github.spotbugs.version>4.8.0</com.github.spotbugs.version>
<com.github.spotbugs.plugin.version>4.7.3.6</com.github.spotbugs.plugin.version>
<com.github.spotbugs.version>4.8.5</com.github.spotbugs.version>
<com.github.spotbugs.plugin.version>4.8.5.0</com.github.spotbugs.plugin.version>
<org.junit.jupiter.version>5.10.2</org.junit.jupiter.version>
<org.hamcrest.version>2.2</org.hamcrest.version>
<org.mockito.version>5.2.0</org.mockito.version>
Expand Down
9 changes: 9 additions & 0 deletions src/main/java/io/cryostat/net/SslConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@ public boolean enabled() {
return strategy.enabled();
}

@Override
protected final void finalize() {}

interface SslConfigurationStrategy {
HttpServerOptions applyToHttpServerOptions(HttpServerOptions options);

Expand Down Expand Up @@ -240,6 +243,9 @@ public HttpServerOptions applyToHttpServerOptions(HttpServerOptions options) {
throw new IllegalStateException(); // extension checked in constructor. should never
// reach this step
}

@Override
protected final void finalize() {}
}

static class KeyCertStrategy implements SslConfigurationStrategy {
Expand Down Expand Up @@ -267,6 +273,9 @@ public HttpServerOptions applyToHttpServerOptions(HttpServerOptions options) {
.setKeyPath(keyPath.toString())
.setCertPath(certPath.toString()));
}

@Override
protected final void finalize() {}
}

static class SslConfigurationException extends Exception {
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/io/cryostat/net/TargetConnectionManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,9 @@ private JFRConnection connect(
}
}

@Override
protected final void finalize() {}

private class ConnectionLoader
implements AsyncCacheLoader<ConnectionDescriptor, JFRConnection> {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,7 @@ List<String> getSelfOrigin() {
return List.of();
}
}

@Override
protected final void finalize() {}
}
3 changes: 3 additions & 0 deletions src/main/java/io/cryostat/rules/MatchExpressionValidator.java
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,7 @@ private String validate(String name, String matchExpression)
}
return matchExpression;
}

@Override
protected final void finalize() {}
}
3 changes: 3 additions & 0 deletions src/main/java/io/cryostat/rules/Rule.java
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@ private static String validateEventSpecifier(String eventSpecifier)
return eventSpecifier;
}

@Override
protected final void finalize() {}

@Override
public boolean equals(Object other) {
if (other == null) {
Expand Down

0 comments on commit 67a9745

Please sign in to comment.