build(core): use -core 2.16.2 from GH pkgs #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
github-actions
bot
added
the
needs-triage
andrewazores
removed
safe-to-test
needs-triage
github-actions
bot
added
the
needs-triage
andrewazores
removed
the
needs-triage
ebaron
reviewed
Dec 22, 2022
github-actions
bot
added
the
needs-triage
ebaron
approved these changes
Dec 22, 2022
|
Test image available: |
This was referenced Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to cryostatio/cryostat-core#92
See also cryostatio/cryostat-reports#63
Description of the change:
This replaces the inlined
-corebuild with simply retrieving the artifact from the GitHub Packages repository for the dependency.Motivation for the change:
This simplifies the CI setup and should also reduce the total CI run time since the artifact is built once (on release) and then each consuming project should cache it, or at worst redownload it rather than rebuild it.