Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix github label from being applied on every pull-request target action #1335

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Jan 17, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1334

Description of the change:

Allows github-actions bot to only apply the needs-triage label when a pull request is opened or re-opened. Also see https://github.com/cryostatio/cryostat/issues/1194#issuecomment-1384723406

Motivation for the change:

See #1334. This is annoying as every time someone added commits or force pushed, the label is applied and we need to remove it again in order for CI tests to run.

How to manually test:

  1. None

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1335-3fcca6dfce2e65055500c9bd04c83d00cdd42e2f sh smoketest.sh

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores merged commit 7fbcacf into cryostatio:main Jan 17, 2023
@maxcao13 maxcao13 deleted the fix-needs-triage branch January 17, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] needs-triage doesn't need to be applied on every pull-request-target action
3 participants