Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(smoketest): update agents config #1345

Merged
merged 2 commits into from
Jan 30, 2023
Merged

test(smoketest): update agents config #1345

merged 2 commits into from
Jan 30, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to cryostatio/cryostat-agent#49
Related to cryostatio/cryostat-agent#27

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jan 30, 2023
@andrewazores
test(smoketest): update agents config
d88e63c 
Signed-off-by: Andrew Azores <aazores@redhat.com>
@andrewazores andrewazores added test and removed needs-triage Needs thorough attention from code reviewers labels Jan 30, 2023
@mergify mergify bot added the safe-to-test label Jan 30, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1345-d88e63c77e3afb96f4e2197ef5beedab608587bf sh smoketest.sh

tthvo
tthvo previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe forquarkus-test-agent-0, we should add a comment to say it is a faulty one?

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1345-9a3d9a27a385fe80f9a92bc6487419e525b6cd7c sh smoketest.sh

@andrewazores andrewazores merged commit b0a8003 into cryostatio:main Jan 30, 2023
@andrewazores andrewazores deleted the smoketest-agents branch January 30, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
safe-to-test test
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @tthvo