fix(k8s): no implicit own-namespace watching #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
no-implicit-own-namespace
branch
from
b21cab0 to
db83791
Compare
|
Test image available: |
ebaron
reviewed
Feb 21, 2023
src/main/java/io/cryostat/platform/internal/OpenShiftPlatformStrategy.java
Outdated
Show resolved
Hide resolved
andrewazores
force-pushed
the
no-implicit-own-namespace
branch
2 times, most recently
from
874d443 to
88e30e2
Compare
|
Test image available: |
andrewazores
force-pushed
the
no-implicit-own-namespace
branch
2 times, most recently
from
fc7c3c6 to
68fc2df
Compare
|
Test image available: |
avoid eager creation of resources that may not be used by non-selected runtime platform mechanisms Signed-off-by: Andrew Azores <aazores@redhat.com>
Signed-off-by: Andrew Azores <aazores@redhat.com>
andrewazores
force-pushed
the
no-implicit-own-namespace
branch
from
68fc2df to
826e426
Compare
|
Test image available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1365
Description of the change:
This removes the own-namespace from being implicitly included in the list of watched namespaces in k8s environments.
Motivation for the change:
The end user, or managing Cryostat Operator, should explicitly list any and all namespaces that they want the Cryostat instance to watch. The implicit inclusion of Cryostat's own namespace restricted users' choices since it was not previously possible to have Cryostat not watch that namespace and discover itself.
How to manually test:
CRYOSTAT_K8S_NAMESPACESenvironment variable to ex.CRYOSTAT_K8S_NAMESPACES=myns1,myns2.