-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): use boolean parameter for StartRecordingMutator restart
#1406
Merged
andrewazores
merged 3 commits into
cryostatio:main
from
maxcao13:fix-graphql-recording-mutator
Mar 14, 2023
Merged
fix(graphql): use boolean parameter for StartRecordingMutator restart
#1406
andrewazores
merged 3 commits into
cryostatio:main
from
maxcao13:fix-graphql-recording-mutator
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcao13
force-pushed
the
fix-graphql-recording-mutator
branch
from
March 14, 2023 02:23
1835723
to
7e9613d
Compare
Test image available:
|
tthvo
previously approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for helping :D
src/main/java/io/cryostat/net/web/http/api/v2/graph/StartRecordingOnTargetMutator.java
Outdated
Show resolved
Hide resolved
Anything else expected or can this PR be unmarked as draft? |
Test image available:
|
andrewazores
approved these changes
Mar 14, 2023
Test image available:
|
tthvo
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1403
Description of the change:
Allows restart to be specified by a boolean parameter.
How to manually test:
Try a query like:
vs