-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): use array format as label input #1411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the label key does not accept forward slash |
10 tasks
andrewazores
previously approved these changes
Mar 14, 2023
Opps forgot to update tests. Looking into it now. |
tthvo
force-pushed
the
start-rec-mutator
branch
from
March 14, 2023 18:08
da0db80
to
4e0acd3
Compare
Signed-off-by: Thuan Vo <thvo@redhat.com>
tthvo
force-pushed
the
start-rec-mutator
branch
from
March 14, 2023 18:12
4e0acd3
to
598d15e
Compare
Test fix makes sense. |
I think it is related to the thread local issue that you mentioned? |
Yea, that's the same bug. |
Test image available:
|
Nice all passed now :D |
andrewazores
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1407
Description of the change:
Use array format for label input similar to metadata mutator.
Motivation for the change:
See #1407
How to test
Try this query: