Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): add podman.socket for running run.sh/smoketest.sh #1594

Merged
merged 1 commit into from
Jul 26, 2023
Merged

docs(README): add podman.socket for running run.sh/smoketest.sh #1594

merged 1 commit into from
Jul 26, 2023

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1532

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jul 25, 2023
@mwangggg mwangggg added docs safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Jul 25, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1594-6e2ea4f6e13ef0746c7de39994347ffdb8886566-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1594-6e2ea4f6e13ef0746c7de39994347ffdb8886566-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1594-6e2ea4f6e13ef0746c7de39994347ffdb8886566-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1594-6e2ea4f6e13ef0746c7de39994347ffdb8886566-linux-amd64 sh smoketest.sh

@andrewazores andrewazores merged commit bff37a1 into cryostatio:main Jul 26, 2023
mergify bot pushed a commit that referenced this pull request Jul 26, 2023
@mwangggg @mergify
docs(README): add podman.socket for running run.sh/smoketest.sh (#1594)
6f072aa 
(cherry picked from commit bff37a1)
@mergify mergify bot mentioned this pull request Jul 26, 2023
Merged
@mwangggg mwangggg deleted the update_README branch July 26, 2023 14:41
andrewazores pushed a commit that referenced this pull request Jul 26, 2023
@mergify @mwangggg
docs(README): add podman.socket for running run.sh/smoketest.sh (#1594)…
6c1a320 
… (#1596)

(cherry picked from commit bff37a1)

Co-authored-by: Ming Yu Wang <90855268+mwangggg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport docs safe-to-test
Projects
No open projects
2.3.1 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] README does not document required podman.sock for run.sh/smoketest.sh
2 participants
@mwangggg @andrewazores