-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): build_test command enhancements #1683
Conversation
/build_test |
To run smoketest:
|
do you have a demo we can take a look at? |
Couldn't run a demo yesterday because of the missing logic on |
5b25a82
to
5555a74
Compare
cryostatio/cryostat-core#266 (comment) - following this discussion, could you remove the permissions in the |
https://github.com/aali309/cryostat/actions/runs/6410504392/job/17403950446.. This is a demo run.. will need help to tackle this where |
5555a74
to
bcfbf71
Compare
|
bcfbf71
to
34c5021
Compare
99aa20d
to
bb9a36d
Compare
/request_review |
sample run after extra conditions |
Added the test failure message as well & intentionally failed the test to see sample run WITH ALL TESTs passing LINK: https://github.com/aali309/cryostat/actions/runs/6659291198 |
bf4b664
to
f985d53
Compare
Very nice, that looks like it's working really well. I still had those two comments before - one small question and one small refactor/cleanup suggestion. Anyone else have any review feedback? I think this is really close to being done and ready for merge. |
f985d53
to
c714489
Compare
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1634
Description of the change:
/retest
to simply rerun the tests without a rebuildMotivation for the change:
provide enhancements to the existing command
/build_test
How to manually test: