Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update -core version, correct constructor invocation #1848

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


@andrewazores andrewazores requested a review from a team as a code owner January 5, 2024 21:06
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jan 5, 2024
@andrewazores andrewazores added dependencies Pull requests that update a dependency file chore Refactor, rename, cleanup, etc. and removed needs-triage Needs thorough attention from code reviewers labels Jan 5, 2024
@mergify mergify bot added the safe-to-test label Jan 5, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Workflow started at 1/5/2024, 4:08:03 PM. View Actions Run.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1848-c3b7f658822c90f8cab047718746ba3a34adb029-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1848-c3b7f658822c90f8cab047718746ba3a34adb029-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1848-c3b7f658822c90f8cab047718746ba3a34adb029-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1848-c3b7f658822c90f8cab047718746ba3a34adb029-linux-arm64 sh smoketest.sh

Copy link
Contributor

github-actions bot commented Jan 5, 2024

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores merged commit 8ae79bc into cryostatio:main Jan 5, 2024
15 of 17 checks passed
@andrewazores andrewazores deleted the core-2.26.0 branch January 5, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant