Increase test timeouts to reduce likelihood of false negatives #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexjsenn
previously approved these changes
Aug 5, 2020
|
@jiekang does this help with the reliability of your builds at all? I don't seem to hit these failures as often as everyone else, so it's hard for me to know for sure. |
|
Of course, a real fix for the unit tests by not relying on an actual wall clocker timer and instead using a faked executor or similar would be an even better solution, but that's a good bit more involved. |
andrewazores
force-pushed
the
test-timeouts
branch
from
29c0156 to
fb903b2
Compare
Decrease likelihood of false negatives due to system load pressure and other external factors
andrewazores
force-pushed
the
test-timeouts
branch
from
fb903b2 to
20ac5e8
Compare
aali309
pushed a commit
to aali309/cryostat-legacy
that referenced
this pull request
Jul 22, 2024
… 1.19.1 to 1.19.2 (cryostatio#228) build(deps): bump com.google.googlejavaformat:google-java-format Bumps [com.google.googlejavaformat:google-java-format](https://github.com/google/google-java-format) from 1.19.1 to 1.19.2. - [Release notes](https://github.com/google/google-java-format/releases) - [Commits](google/google-java-format@v1.19.1...v1.19.2) --- updated-dependencies: - dependency-name: com.google.googlejavaformat:google-java-format dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.