Backend state changes #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/cryostat/net/web/http/api/v1/RecordingDeleteHandler.java
Show resolved
Hide resolved
|
Looks good otherwise! Thanks for taking this on. |
src/main/java/io/cryostat/net/web/http/api/v1/RecordingsPostHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/net/web/http/api/v1/TargetRecordingDeleteHandler.java
Outdated
Show resolved
Hide resolved
…otification category
andrewazores
approved these changes
Apr 28, 2021
|
@Josh-Matsuoka do you have any interest in looking at cryostatio/cryostat-web#165 ? That's the corresponding frontend issue. This would simply entail adding notification handlers for each of these new notification types emitted and either using the notification payload to update the view, or if that's infeasible then to use the notification as a trigger to poll for fresh data. |
|
I can take a look at that, sure |
aali309
pushed a commit
to aali309/cryostat-legacy
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses cryostatio/cryostat#354 , sending events on the Notification channel when recordings are created/deleted, archived, and templates are uploaded/deleted. I've adjusted the tests accordingly.