Use older 2.x Surefire/Failsafe test runner plugins #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hareetd
previously approved these changes
Jun 8, 2021
3.x preview releases are not correctly running JUnit 5 parameterized tests in all scenarios
andrewazores
force-pushed
the
unit-test-not-run
branch
from
b65536f to
ad8836f
Compare
|
Cleanly rebased on top of @hareetd 's fix for the hidden failures. This should now run and pass all unit tests. |
hareetd
approved these changes
Jun 15, 2021
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 23, 2021
3.x preview releases are not correctly running JUnit 5 parameterized tests in all scenarios
andrewazores
added a commit
that referenced
this pull request
Jun 23, 2021
* Fix previously hidden unit test failures (#512) * Remove null test cases and change incorrect Matcher functionality * Fix incorrect class mocking which causes tests to pass for the wrong reason * Maintain consistency between tests by allowing use of the same recording name * Use older 2.x Surefire/Failsafe test runner plugins (#503) 3.x preview releases are not correctly running JUnit 5 parameterized tests in all scenarios Co-authored-by: Hareet Dhillon <hareet.dhillon@gmail.com>
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 24, 2021
3.x preview releases are not correctly running JUnit 5 parameterized tests in all scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x preview releases are not correctly running JUnit 5 parameterized tests in all scenarios
This PR is expected to fail CI checks, since it exposes two manually-discovered unit test failures which are currently silently lost with the Surefire/JUnit configuration in use. @hareetd has a correction for those two test cases.
Fixes #502