Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth request event #522

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Jun 17, 2021

Related #461

Not tested yet.
How can I trigger the OpenShiftAuthManager to emit an event?

@jan-law jan-law requested a review from andrewazores June 17, 2021 20:04
@andrewazores
Copy link
Member

How can I trigger the OpenShiftAuthManager to emit an event?

You would need to build your Cryostat image and push it to a registry (ex. quay.io , under your own account/namespace). Then you can deploy your custom Cryostat image in CRC using the Operator. Once it's running in CRC it will automatically select the OpenShiftAuthManager, so set up a recording with the ALL metatemplate and after that most things you do will trigger the event to be recorded.

andrewazores
andrewazores previously approved these changes Jun 25, 2021
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just built and deployed this to my crc instance and it looks great.

@andrewazores
Copy link
Member

authrequest.tar.gz

@jan-law
Copy link
Contributor Author

jan-law commented Jun 25, 2021

Glad it's working! I actually haven't been able to test this yet because my crc start still isn't working. Guillaume from the crc team has been helping me with the issue

@jan-law jan-law marked this pull request as ready for review June 25, 2021 14:58
@jan-law jan-law force-pushed the Add-auth-API-request-event branch from df08527 to 7095421 Compare June 25, 2021 15:11
@@ -3,13 +3,24 @@
see Window -> Flight Recorder Template Manager.
-->
<configuration version="2.0" label="Cryostat" description="Continuous self-profiling for Cryostat" provider="Cryostat">
<event name="io.cryostat.net.TargetConnectionManager.JMXConnectionOpened">
<event name="io.cyostat.net.OpenShiftAuthManager.AuthRequest">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: 'cyostat'

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The web-client submodule shouldn't be updated by this PR

@jan-law jan-law force-pushed the Add-auth-API-request-event branch from 2426ac6 to f30a7a7 Compare June 25, 2021 15:37
@andrewazores andrewazores merged commit eca1cad into cryostatio:main Jun 25, 2021
@jan-law jan-law deleted the Add-auth-API-request-event branch June 25, 2021 15:45
andrewazores pushed a commit to andrewazores/cryostat that referenced this pull request Jun 29, 2021
aali309 pushed a commit to aali309/cryostat-legacy that referenced this pull request Jul 22, 2024
… 3.2.5 to 3.3.0 (cryostatio#522)

build(deps): bump org.apache.maven.plugins:maven-failsafe-plugin

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.3.0.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.3.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants