Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cryostat template to image #541

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jun 25, 2021

Related to #461

This allows the Cryostat.xml (rename cryostat.jfc) template to be listed as an available TARGET template and used identically to the standard default.jfc and profile.jfc templates/configurations.

cryostat-self-template-2021-06-25_12.23.41.mp4

@andrewazores andrewazores requested review from hareetd and jan-law June 25, 2021 16:26
Copy .jfr event configuration template into base image's JDK jfr/lib directory, allowing Cryostat to report the cryostat.jfc as an available TARGET template
@andrewazores andrewazores force-pushed the add-cryostat-template-to-image branch from b0be331 to 4e126cc Compare June 25, 2021 16:27
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will hold back on approving until after Hareet looks at it

Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores merged commit 185b1fb into cryostatio:main Jun 25, 2021
@andrewazores andrewazores deleted the add-cryostat-template-to-image branch June 25, 2021 17:02
andrewazores added a commit to andrewazores/cryostat that referenced this pull request Jun 29, 2021
* Rename file

* Copy cryostat.jfc into built image

Copy .jfr event configuration template into base image's JDK jfr/lib directory, allowing Cryostat to report the cryostat.jfc as an available TARGET template

* Add itest for cryostat.jfc availability
aali309 pushed a commit to aali309/cryostat-legacy that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants