-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(ci): Push built CI images to Quay #545
Conversation
Cool, looks good, although I do also think pushing/tagging an image for every upstream commit might be a bit much. Is there a way to do it for Oh, I do have a question regarding the |
We could use the
I'm still not clear exactly how the workflows work in non-default branches, but we definitely want [1] https://docs.github.com/en/actions/reference/events-that-trigger-workflows#release |
I suppose we would, but this would mean we either have to update the pom version along with every PR after the first beta, or if we don't, then existing beta tags on quay.io would be overwritten by later builds with the same version. I guess betas would come off an upstream version branch anyway, so updating the pom along with every backport PR would be okay. |
* Push CI builds to quay.io * Extract image name to environment variable * Update step name * Name steps * Fix image property
* Push CI builds to quay.io * Extract image name to environment variable * Update step name * Name steps * Fix image property
This PR adds steps to our CI workflow that push the build image to Quay. This uses the
redhat-actions/push-to-registry
action. The step only runs on push, excluding forks. The image tags pushed to Quay are the image version defined in the POM (currently2.0.0-SNAPSHOT
),latest
, and the commit SHA. The latter creates a new tag upon each commit. I'm not sure if we want this. It's nice for traceability, but will end up creating a lot of tags.The push is done by a robot account in Quay, whose credentials will be stored in a Github secret [1]. To test, I temporarily substituted the Cryostat account for my own. The results can be seen below:
CI on PR, not pushed to Quay: https://github.com/ebaron/cryostat/runs/2975581732
CI on push, pushed to Quay: https://github.com/ebaron/cryostat/runs/2975629893
[1] https://docs.github.com/en/actions/reference/encrypted-secrets