Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(report): Add report itests #615

Merged
merged 11 commits into from
Aug 4, 2021
Merged

test(report): Add report itests #615

merged 11 commits into from
Aug 4, 2021

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Jul 29, 2021 •
edited
Loading

Related #474

Tests the HTTP 200 and 404 scenarios for the TargetReportGetHandler and ReportGetHandler.

TargetReportIT downloads the report directly from the JVM whereas ReportIT also makes one more call to save the recording to archive before getting the report from the archive.

Update: All tests are passing
Summary of test failures:
1) TargetReportGetHandler throws 500 instead of 404 when getting a non-existent recording (should pass after #614 is merged)
2) When the Jsoup HTML parser parses the report, it returns a list of Unexpected Token errors. See review below

@jan-law jan-law added the test label Jul 29, 2021
@jan-law jan-law marked this pull request as ready for review August 3, 2021 17:52
@andrewazores andrewazores merged commit b3999f5 into cryostatio:main Aug 4, 2021
@jan-law jan-law deleted the itest-report branch August 4, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-law @andrewazores