Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(targetconnectionmanager): cache TTL/size configuration #638

Merged
merged 8 commits into from
Aug 10, 2021
Merged

feat(targetconnectionmanager): cache TTL/size configuration #638

merged 8 commits into from
Aug 10, 2021

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 10, 2021 •
edited
Loading

Fixes #637

@andrewazores andrewazores added the feat New feature or request label Aug 10, 2021
@andrewazores andrewazores force-pushed the tcm-cache-size-ttl-config branch from 5372b3e to aa3c6e3 Compare August 10, 2021 14:44
@andrewazores
Copy link
Member Author

@hareetd or @jan-law , would either of you like to review this?

hareetd
hareetd reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go besides the paragraph I mentioned, the rest of the comments are mainly just questions for my own understanding.

src/main/java/io/cryostat/net/TargetConnectionManager.java Show resolved Hide resolved
src/main/java/io/cryostat/net/TargetConnectionManager.java Show resolved Hide resolved
src/main/java/io/cryostat/net/NetworkModule.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/test/java/io/cryostat/net/TargetConnectionManagerTest.java Outdated Show resolved Hide resolved
hareetd
hareetd previously approved these changes Aug 10, 2021
View reviewed changes
@andrewazores andrewazores merged commit f7507eb into cryostatio:main Aug 10, 2021
@andrewazores andrewazores deleted the tcm-cache-size-ttl-config branch August 10, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hareetd hareetd hareetd approved these changes

Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection cache size and TTL should be configurable
2 participants
@andrewazores @hareetd