fix(recordingoptions): client may explicitly unset options #640
Conversation
Trimmed stacktrace output makes uncaught unit test exceptions difficult to debug at a glance
andrewazores
force-pushed
the
recording-options-unset
branch
from
25146c0 to
bfeeb45
Compare
andrewazores
force-pushed
the
recording-options-unset
branch
from
e9e0ba4 to
e56bcb1
Compare
|
Out of curiosity, how exactly was not being able to explicitly unset the recording options leading to the test failures from before? |
This seems to have been the key: https://github.com/cryostatio/cryostat/pull/640/files#diff-5191e54db18231ddfc4a99eb2dd6289336bc68561507563c9c471d4f8986b0d7L74 When retrieving the options from the JVM, the default value being unset is reported as 0. But, explicitly setting a value and then "resetting" it to 0 seems to turn out to actually tell the target JVM to not record anything at all, as in the recording may have a maximum size of 0 bytes. There's probably a better/correct way to get the |
src/test/java/io/cryostat/net/web/http/api/v1/TargetRecordingOptionsPatchHandlerTest.java
Show resolved
Hide resolved
…6.2 to 4.8.6.3 (cryostatio#640) build(deps): bump com.github.spotbugs:spotbugs-maven-plugin Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.6.2 to 4.8.6.3. - [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases) - [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.8.6.2...spotbugs-maven-plugin-4.8.6.3) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Related to #632
Fixes #634