-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(health): add cryostatVersion #650
feat(health): add cryostatVersion #650
Conversation
Huh, the |
That is odd. What about trying |
That could work, but it just gives the shortened hash of the current commit - I was hoping to get the name of the tag pointing to the current commit, if any, which In particular, I wanted the human-readable tag name output because I think this will end up displayed somewhere in -web. But the short hash is probably good enough. |
Ah, I think the problem with
Looks like there are no tags present, so |
cad25f2
to
5be5cf0
Compare
5be5cf0
to
62fb5b5
Compare
Looks like that worked. I'm putting together a small -web PR as well that goes with this, so I'll update this PR with a commit to update the web-client submodule as well after that is ready and merged in the -web side. |
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With your feature branch checked out, I get this:
$ git describe --dirty --long --always
v0.20.0-209-gc4ed02f8
Kinda weird, but maybe not an issue in practice.
Hmm, there should be a more recent "ancestor" tag than v0.20.0. What if you do a
|
If I check out that |
That did the trick. I see the same now. |
Fixes #649
Depends on cryostatio/cryostat-web#241