Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conf): use only one conf dir location #664

Merged
merged 4 commits into from
Aug 27, 2021
Merged

fix(conf): use only one conf dir location #664

merged 4 commits into from
Aug 27, 2021

Conversation

andrewazores
Copy link
Member

Fixes #663

@andrewazores andrewazores requested review from ebaron and jan-law August 26, 2021 20:35
@andrewazores andrewazores added fix and removed fix labels Aug 26, 2021
ebaron
ebaron reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get Error: statfs /home/ebaron/git/container-jfr/conf: no such file or directory. I think we need a mkdir in run.sh similar to clientlib and truststore.

@andrewazores
Copy link
Member Author

I get Error: statfs /home/ebaron/git/container-jfr/conf: no such file or directory. I think we need a mkdir in run.sh similar to clientlib and truststore.

Ah, good catch.

@andrewazores andrewazores mentioned this pull request Aug 26, 2021
Merged
ebaron
ebaron approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with BasicAuthManager and credentials stored under ./conf/.

@andrewazores andrewazores merged commit 61f507a into cryostatio:main Aug 27, 2021
@andrewazores andrewazores deleted the single-conf-dir branch August 27, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@jan-law jan-law Awaiting requested review from jan-law

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MainModule and ConfigurationModule both provide configuration directory paths
2 participants
@andrewazores @ebaron