fix(serviceref): guard against nulls #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaron
approved these changes
Oct 5, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
* fix(serviceref): guard against nulls * test(serviceref): add unit tests * chore(serviceref): apply spotless formatting (cherry picked from commit 24aff86)
ebaron
pushed a commit
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699
From various readings, it seems that the obj.metadata field is always present, but the labels and annotations properties may not always be (but "should"). Here I add guards within the ServiceRef methods to treat null labels/annotations as if they are empty Maps to avoid NPEs in cases where platform implementations may return nulls to us.
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/
https://kubernetes.io/docs/concepts/overview/working-with-objects/kubernetes-objects/
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata