fix(pom): use latest jfr-datasource and grafana-dashboard #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
run-smoketest-use-pom-versions
branch
from
2061f58 to
3d86c14
Compare
andrewazores
force-pushed
the
run-smoketest-use-pom-versions
branch
from
383c9b9 to
aea0d04
Compare
jan-law
reviewed
Dec 6, 2021
hareetd
approved these changes
Dec 6, 2021
andrewazores
added a commit
that referenced
this pull request
Dec 6, 2021
) (#778) * fix(pom): use latest jfr-datasource and grafana-dashboard (#774) * fix(pom): use latest jfr-datasource and grafana-dashboard Fixes #772 * chore(run.sh): use versions and port numbers from pom.xml by default * fixup! chore(run.sh): use versions and port numbers from pom.xml by default (cherry picked from commit 0595551) * use jfr-datasource and grafana-dashboard 2.0.0 Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
This updates the
pom.xmlversions for jfr-datasource and cryostat-grafana-dashboard used in integration testing from1.0.0tolatest. Once the backport PR is opened I will change these versions fromlatestinmainto2.0.0in thev2backport release version. Later, when2.1.0release is approaching and we create the upstream branch for it, then that branch should also havelatestreplaced by2.1.0for these two itest container versions as well.Additionally, this PR uses
xpathinrun.shandsmoketest.shto readpom.xmlto determine things like the JMX and HTTP API port numbers to use by default. This is just a cleanup so that the values aren't hardcoded in multiple places, which is what leads to some places lagging behind as was the problem with the itest container versions above.