Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(archiveupload): Delete improperly-named file uploads #787

Merged
merged 3 commits into from
Jan 7, 2022
Merged

fix(archiveupload): Delete improperly-named file uploads #787

merged 3 commits into from
Jan 7, 2022

Conversation

hareetd
Copy link
Contributor

@hareetd hareetd commented Dec 20, 2021

Fixes #784

@hareetd hareetd added the fix label Dec 20, 2021
@hareetd hareetd requested a review from andrewazores December 20, 2021 22:21
andrewazores
andrewazores reviewed Dec 21, 2021
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks reasonable. Could you add/update unit tests?

@hareetd
Copy link
Contributor Author

hareetd commented Dec 21, 2021

Sounds good, will do.

@hareetd
Copy link
Contributor Author

hareetd commented Jan 6, 2022 •
edited
Loading

TargetReportIT failure looks like another instance of #666.

Edit: Passed on re-run

@andrewazores andrewazores merged commit 6570f82 into cryostatio:main Jan 7, 2022
@hareetd hareetd deleted the delete-improperly-named-files branch January 7, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V1 RecordingsPostHandler does not delete improperly-named files
2 participants
@hareetd @andrewazores