Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Add cgroups v2 configuration instructions to README #790

Merged
merged 8 commits into from
Jan 11, 2022
Merged

docs(readme): Add cgroups v2 configuration instructions to README #790

merged 8 commits into from
Jan 11, 2022

Conversation

hareetd
Copy link
Contributor

@hareetd hareetd commented Jan 11, 2022

Fixes #789

@hareetd hareetd added docs chore Refactor, rename, cleanup, etc. labels Jan 11, 2022
@hareetd hareetd requested a review from andrewazores January 11, 2022 00:49
@hareetd hareetd changed the title update(readme): Add cgroups v2 configuration instructions to README docs(readme): Add cgroups v2 configuration instructions to README Jan 11, 2022
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this text a bit confusing. Podman and Docker are separate container runtimes, although Podman (and all other OCI tooling) is heavily inspired by Docker. I don't think it should be necessary to have Docker installed alongside Podman, and the Note: at the bottom is talking about configuring Podman's runc version but links to Docker documentation?

@hareetd
Copy link
Contributor Author

hareetd commented Jan 11, 2022

When I attempted to build/run cryostatio/cryostat-reports#7 my Docker installation complained after enabling cgroups v2 so I had to update it accordingly. This made me think that Podman and Docker were linked when in reality it's likely because I had both installed on the system. The Note: regarding the Podman runtime is because of this confusion. I'll remove any mention of Docker from my changes, thanks.

@andrewazores
Copy link
Member

Sounds good. FWIW I don't have Docker installed at all and haven't in quite some time - probably removed since F30/cgroups v1, if not earlier.

@hareetd
Copy link
Contributor Author

hareetd commented Jan 11, 2022

Makes sense, I only installed it since the OperatorHub.io test suite was refusing to work with Podman.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@andrewazores andrewazores merged commit 9d8e9b7 into cryostatio:main Jan 11, 2022
@hareetd hareetd deleted the update-readme-cgroups branch January 11, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README with proper cgroups configuration for local podman setup
2 participants