feat(jdp): add env vars to enable/configure JDP #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
feat
ebaron
previously approved these changes
Feb 2, 2022
|
I had another thought about this for backporting. Should we keep the default as true in the backport for backwards compatibility? |
|
That's a good idea. I'll set the default to |
andrewazores
force-pushed
the
optional-jdp
branch
from
0402eed to
ef0c358
Compare
andrewazores
force-pushed
the
optional-jdp
branch
from
ef0c358 to
b98695f
Compare
ebaron
approved these changes
Feb 2, 2022
mergify bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
* feat(jdp): add env var to enable JDP * feat(jdp): add env vars for JDP addr and port * enable JDP in development tests * fix(jdp): broken env var checks * default JDP to true for backward compatibility (cherry picked from commit 5fd17e7) # Conflicts: # README.md # pom.xml # run.sh
andrewazores
added a commit
that referenced
this pull request
Feb 9, 2022
* feat(jdp): add env vars to enable/configure JDP (#804) * feat(jdp): add env var to enable JDP * feat(jdp): add env vars for JDP addr and port * enable JDP in development tests * fix(jdp): broken env var checks * default JDP to true for backward compatibility (cherry picked from commit 5fd17e7) # Conflicts: # README.md # pom.xml # run.sh * resolve README conflicts * resolve run.sh conflicts * resolve pom.xml conflicts * fixup! resolve README conflicts * fixup! fixup! resolve README conflicts * fixup! fixup! fixup! resolve README conflicts Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803