fix(notifications): unlimited max simultaneous websocket connections #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
end user can continue to use CRYOSTAT_MAX_WS_CONNECTIONS to set a cap, otherwise Integer.MAX_VALUE is used
andrewazores
force-pushed
the
ws-max-connections
branch
from
4aa29ed to
d62118e
Compare
jan-law
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Works as expected.
It'd be a good idea to update the operator docs before the 2.1 release too:
https://github.com/cryostatio/cryostat-operator/blob/main/docs/config.md#cryostat-client-options
https://github.com/cryostatio/cryostat-operator/blob/main/api/v1beta1/cryostat_types.go#L83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830