feat(recordings): set recording template in label #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
metadata-recording-settings
branch
from
9a9c59b to
3f60c43
Compare
andrewazores
force-pushed
the
metadata-recording-settings
branch
from
68267fc to
1b31e9a
Compare
jan-law
reviewed
Mar 17, 2022
src/main/java/io/cryostat/net/web/http/api/beta/RecordingMetadataLabelsPostHandler.java
Show resolved
Hide resolved
jan-law
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #860
The main feature work is a tiny change in the
feat(recordings): set recording template in labelcommit. The commit before that is some simple refactoring (affecting a lot of call sites, but a minor change in itself) to generalize theRecordingMetadataManagerto deal with theMetadatatype rather than just the labels map, so that we can more easily extend theMetadatato contain other fields in the future. And the first commit in the series fixes an oversight where GraphQL responses did not include the metadata/labels properties, so there was a discrepancy there vs the standard HTTP API.