Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recordings): disallow labels with whitespace #867

Merged
merged 3 commits into from
Mar 18, 2022
Merged

fix(recordings): disallow labels with whitespace #867

merged 3 commits into from
Mar 18, 2022

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Mar 17, 2022 •
edited by andrewazores
Loading

@jan-law jan-law added the fix label Mar 17, 2022
@jan-law jan-law requested a review from andrewazores March 17, 2022 20:37
@jan-law jan-law mentioned this pull request Mar 17, 2022
Merged
andrewazores
andrewazores reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, update web-client please

@github-actions
Copy link
Contributor

This PR/issue depends on:

@andrewazores andrewazores merged commit f1d12c9 into cryostatio:main Mar 18, 2022
@jan-law jan-law deleted the label-validation branch April 7, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recording labels should disallow whitespace, allow other characters
2 participants
@jan-law @andrewazores