Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): Add query for all archived recordings #924

Merged
merged 10 commits into from
Jul 29, 2022
Merged

feat(graphql): Add query for all archived recordings #924

merged 10 commits into from
Jul 29, 2022

Conversation

hareetd
Copy link
Contributor

@hareetd hareetd commented May 11, 2022

Fixes #923

Add a query for all archived recordings with the ability to filter on target source, name, and labels. Besides differentiating between JVM targets, the target source can also be used to retrieve only those recordings uploaded directly to archives (i.e. recordings not associated with a target).

Change the subdirectory name for uploaded recordings from "unlabelled" to "uploads" for clarity.

Add a new field for archived recordings in the GraphQL Schema containing aggregate information such as the count of recordings.

Depends on cryostatio/cryostat-web#431

@andrewazores
Copy link
Member

andrewazores commented May 12, 2022

types.graphqls needs to be updated as well to reflect the new addition to ArchivedRecordingFilterInput. This is just used for request validation to ensure that it matches the expected schema.

@hareetd hareetd marked this pull request as ready for review May 13, 2022 22:01
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll wait for cryostatio/cryostat-web#431 and the corresponding web-client submodule update before merging.

andrewazores
andrewazores previously approved these changes Jul 29, 2022
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase please, I can't do it automatically as GitHub says there are conflicts.

@github-actions
Copy link
Contributor

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Enable revamp/redesign of the -web "All Archives" view
2 participants