test(resources): multi-namespace support for test resources #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is long, but a lot of the changes are a result of changing functions to methods. I've added a
TestResourcesstruct that is embedded into thecryostatTestInputused by the controller tests. Several fields have moved to theTestResourcestype where it makes sense:minimal,tls, etc. These would be fields that have some effect on the creation of the test objects. In addition to this, a newnamespacefield is added. Modifying this field affects the namespace of all subsequently created test objects.By changing the test object creation from functions to methods, I've been able to reduce the parameter bloat, which hopefully results in more readable tests. I've tried quite a few iterations of this refactoring, before settling on this approach. Let me know what you think.
Fixes: #506