-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): setup CI to push scorecard, bundle images and run scorecard #588
Conversation
601c73f
to
4bd8cea
Compare
a944f83
to
be8aee9
Compare
7d569db
to
d64efe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this action before: https://github.com/helm/kind-action. Not sure if it would make things any easier for this PR, but wanted to let you know it exists.
Thanks! We still need to pass in the path to config file. Tho, we can set a fixed version of kind and kubectl. Is there a version we want to set or whatever version (seems like latest) comes with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed that's missing here is a CI image for the operator controller image. This means that any code changes aren't reflected in the bundle image, only YAML changes. We should push the operator image to ghcr.io and then pass that image to make bundle
with OPERATOR_IMG
.
Do u think we should patch the manager's pod template or the operator SA with the pullImageSecret? |
https://github.com/tthvo/cryostat-operator/actions/runs/5082564293/jobs/9132453979 |
Not the most intuitive way to patch imagePullSecrets but seems to work nicely: Patch: 46e6741 Test run: https://github.com/tthvo/cryostat-operator/actions/runs/5083194894/jobs/9133896077 How about that? |
Signed-off-by: Thuan Vo <thvo@redhat.com>
This PR/issue depends on:
|
@ebaron Latest run after rebasing: https://github.com/tthvo/cryostat-operator/actions/runs/5083932753/jobs/9135558209 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! Awesome job on getting this done @tthvo! Thank you!
This is awesome, finally knocking off a major piece of that puzzle for doing CI in a k8s environment. |
Niceee thanks you^^ Happy I could help with it :)) |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #227, #493
Depends on #589
Description of the change:
Motivation for the change:
See #227, #493
How to manually test:
See CI job status:
Push jobs on
main
push is failing on my repo since it does not have access tocryostat/cryostat
but build steps seems to work fine.Others
We also need to remove checks for
build Expected — Waiting for status to be reported
as CI job name is changed.