commit hash URL can be overridden, is not a link if the URL string is…

… empty
cryostatio · Oct 11, 2022 · 94ff4e8 · 94ff4e8
1 parent e5c2709
commit 94ff4e8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/src/app/About/AboutDescription.tsx b/src/app/About/AboutDescription.tsx
@@ -70,20 +70,28 @@ export const AboutDescription = () => {
     return result.groups?.describe || 'main';
   }, [cryostatVersion, notificationsContext]);
 
+  const versionComponent = React.useMemo(() => {
+    if (build.commitHashUrl) {
+      return (
+        <Text
+          component={TextVariants.a}
+          target="_blank"
+          href={build.commitHashUrl.replace('__REPLACE_HASH__', cryostatCommitHash || '')}
+        >
+          {cryostatVersion}
+        </Text>
+      );
+    } else {
+      return <Text component={TextVariants.p}>{cryostatVersion}</Text>;
+    }
+  }, [build.commitHashUrl, cryostatCommitHash]);
+
   return (
     <>
       <TextContent>
         <TextList component="dl">
           <TextListItem component="dt">Version</TextListItem>
-          <TextListItem component="dd">
-            <Text
-              component={TextVariants.a}
-              target="_blank"
-              href={`https://github.com/cryostatio/cryostat/commits/${cryostatCommitHash}`}
-            >
-              {cryostatVersion}
-            </Text>
-          </TextListItem>
+          <TextListItem component="dd">{versionComponent}</TextListItem>
           <TextListItem component="dt">Homepage</TextListItem>
           <TextListItem component="dd">
             <Text component={TextVariants.a} target="_blank" href={build.homePageUrl}>

diff --git a/src/app/build.json b/src/app/build.json
@@ -1,5 +1,6 @@
 {
   "productName": "Cryostat",
+  "commitHashUrl": "https://github.com/cryostatio/cryostat/commits/__REPLACE_HASH__",
   "homePageUrl": "https://cryostat.io",
   "knownIssuesUrl": "https://github.com/cryostatio/cryostat/issues",
   "fileIssueUrl": "https://github.com/cryostatio/cryostat/issues/new?labels=user+report,bug&body=Affects+__REPLACE_VERSION__",