Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading/deleting Event Templates produces no Notifications #349

Closed
andrewazores opened this issue Nov 30, 2021 · 0 comments · Fixed by #371
Closed

Uploading/deleting Event Templates produces no Notifications #349

andrewazores opened this issue Nov 30, 2021 · 0 comments · Fixed by #371
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

POST /api/v1/templates and DELETE /api/v1/templates/:templateName endpoints both produce a WebSocket notification on success (as well as indicating success by the HTTP status code in the response). However, neither of these produce a graphical notification in the web-client.

At face value this comes down to the NotificationChannel.service.tsx simply not subscribing to the stream of messages with this category. However, this would be a recurring problem with more event categories that are added - and may already be an issue with other categories than the two for Event Templates. There is already some logic in the Notifications.tsx for determining whether a WebSocket message indicates some kind of "action" event (response to a user-initiated or automated API request), a "problem" (some API request failed), reflects WebSocket client activity, or indicates that a target JVM (dis)appeared. Rather than the NotificationsChannel.service.tsx explicitly opting in to some set of categories for which to display notifications, perhaps it should listen to all incoming messages with all categories, and display notifications for all of the ones that are "actions".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant