feat(notifications): service handles and displays all incoming WS messages #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
notification-actions
branch
from
fe457b0 to
153e798
Compare
…sages customized display behaviour can and should be specified for all message event categories, but if an unexpected message is received, it will be displayed with some guess at the correct alert level
configure JVM discovery to not display alert
andrewazores
force-pushed
the
notification-actions
branch
from
153e798 to
2d059bc
Compare
hareetd
reviewed
Feb 8, 2022
hareetd
reviewed
Feb 8, 2022
hareetd
approved these changes
Feb 9, 2022
jan-law
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #349
This refactors the explicit notification handling in the
NotificationChannel, extracting out some configuration objects into aMapto redefine the existing notifications handling for things like WebSocket client activity, or recording start/stop/archive/delete actions.This is then further extended by adding handling for notifications that have a category not specified in the above configuration map. The client will still attempt to display these notifications, but the display will include the raw message category from the WebSocket notification message, and the notification body will simply be the body field of the notification message, without any further contextual information, and likely with JSON formatting tokens present. This is just a catch-all handler in case some backend message is emitted that no frontend support was specifically implemented for. Ideally, it should never actually be triggered, because all message types are accounted for with the customized configuration objects.