Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Reserved labels should be informed to the users #614

Closed
tthvo opened this issue Nov 7, 2022 · 0 comments · Fixed by #626
Closed

[Task] Reserved labels should be informed to the users #614

tthvo opened this issue Nov 7, 2022 · 0 comments · Fixed by #626
Assignees
@tthvo
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tthvo
Copy link
Member

tthvo commented Nov 7, 2022

Right now, we do not inform users of the default labels that will be applied to newly created active recordings. If the user choose a label that has the same key as the defaults, the user-defined one will be discarded.

To reproduce:

  1. Create a recording with label template.type=something:

Screenshot from 2022-11-07 17-19-23

  1. Recording table shows default instead of the user-defined one.

Screenshot from 2022-11-07 17-19-35
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 7, 2022
@tthvo tthvo added bug Something isn't working good first issue Good for newcomers labels Nov 7, 2022
@tthvo tthvo mentioned this issue Nov 10, 2022
Merged
@tthvo tthvo self-assigned this Nov 10, 2022
Repository owner moved this from Todo to Done in 2.3.0 release Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthvo tthvo

Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(labels): add a helper text to label editor tthvo/cryostat-web
1 participant
@tthvo