Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(labels): add a helper text to label editor #626

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Nov 10, 2022

Fixes #614

  • Added a helper text above label editor to inform users about reserved labels. This helper text will change style based on input labels. If there is a label with template.name/template.type, it will turns to warning variant.

  • Added some unit tests for CustomRecordingForm.

Default:

Screenshot from 2022-11-09 22-19-59

Warning:

Screenshot from 2022-11-09 22-20-18

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Nov 10, 2022
@tthvo tthvo changed the title chore(recordings): add a helper text to label editor chore(labels): add a helper text to label editor Nov 10, 2022
@andrewazores andrewazores merged commit 94d5195 into cryostatio:main Nov 10, 2022
@tthvo tthvo deleted the reserved-labels branch November 10, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Reserved labels should be informed to the users
2 participants