Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Metadata file upload should handle parsing error #623

Closed
tthvo opened this issue Nov 9, 2022 · 0 comments · Fixed by #624
Closed

[Task] Metadata file upload should handle parsing error #623

tthvo opened this issue Nov 9, 2022 · 0 comments · Fixed by #624
Assignees
@tthvo
Labels
bug Something isn't working

Comments

@tthvo
Copy link
Member

tthvo commented Nov 9, 2022

If the metadata file has invalid contents, the UI should handle this: either by showing an error text or just return empty. Right now, the UI will be stuck in loading state.

Screenshot from 2022-11-09 16-46-44
@tthvo tthvo added the bug Something isn't working label Nov 9, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 9, 2022
@tthvo tthvo mentioned this issue Nov 9, 2022
Merged
@tthvo tthvo self-assigned this Nov 9, 2022
Repository owner moved this from Todo to Done in 2.3.0 release Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthvo tthvo

Labels
bug Something isn't working
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(label-upload): add error handler for metadata uploads tthvo/cryostat-web
1 participant
@tthvo