Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(label-upload): add error handler for metadata uploads #624

Merged
merged 6 commits into from
Nov 10, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Nov 9, 2022

Fixes #623

Handled parsing error if user uploads invalid metadata label files. The invalid files are shown in a popover on top of the button since inline texts are taking quite some spaces and misaligned. In the background, invalid file contents are ignored (i.e. return empty []).

Screenshot from 2022-11-09 18-11-06

@tthvo tthvo added the fix label Nov 9, 2022
@tthvo
Copy link
Member Author

tthvo commented Nov 9, 2022

Any thoughts on this design?

@andrewazores
Copy link
Member

Design looks good. I think the two texts are mostly saying the same thing though, so either one should be rephrased or the one inside the component body should be removed.

Maybe,
title: "Invalid Selection"
message: "The following files did not contain valid recording metadata:"

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@tthvo
Copy link
Member Author

tthvo commented Nov 9, 2022

I think the two texts are mostly saying the same thing though, so either one should be rephrased or the one inside the component body should be removed.

Nice! Thanks I updated the modal now.

Screenshot from 2022-11-09 18-41-23

@andrewazores
Copy link
Member

LGTM, I'll give @maxcao13 a chance to look at this too

@andrewazores andrewazores force-pushed the metadata-upload-error branch from 26e306d to 11ab4a0 Compare November 9, 2022 23:59
@andrewazores andrewazores merged commit 9954714 into cryostatio:main Nov 10, 2022
@tthvo tthvo deleted the metadata-upload-error branch April 26, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Metadata file upload should handle parsing error
3 participants