-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(label-upload): add error handler for metadata uploads #624
Conversation
Any thoughts on this design? |
Design looks good. I think the two texts are mostly saying the same thing though, so either one should be rephrased or the one inside the component body should be removed. Maybe, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
LGTM, I'll give @maxcao13 a chance to look at this too |
26e306d
to
11ab4a0
Compare
Fixes #623
Handled parsing error if user uploads invalid metadata label files. The invalid files are shown in a popover on top of the button since inline texts are taking quite some spaces and misaligned. In the background, invalid file contents are ignored (i.e. return empty []).