Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Event Types pagination breaks if filter text is present #685

Closed
tthvo opened this issue Nov 21, 2022 · 0 comments · Fixed by #684
Closed

[Task] Event Types pagination breaks if filter text is present #685

tthvo opened this issue Nov 21, 2022 · 0 comments · Fixed by #684
Assignees
Labels
bug Something isn't working

Comments

@tthvo
Copy link
Member

tthvo commented Nov 21, 2022

Related to #595

Right now, pagination states do not take into account the current filtered type rows, which causes the table renders incorrectly if there are less filtered rows than previously (currentPage index will be out of bound).

How To Reproduce

Step 1: Go to Events tab and select Event Types (might need to enter credentials).

Step 2: Click on > on pagination to go to higher indexed page (perhaps page 4-5).

Step 3: Enter CPU Usage on top-left filter. This is a valid name of an available event type.

Step 4: See the bug - No row is shown, pagination shows incorrect state as in below screenshot.

What Is Expected

A single row with event type name CPU Usage and pagination shows 1 of 1 as in the screenshot below.

event-type-pagination-ok

What Actually Happened

No row is shown, pagination shows incorrect state as in below screenshot.

event-type-pagination-broken

@tthvo tthvo added the bug Something isn't working label Nov 21, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 21, 2022
@tthvo tthvo self-assigned this Nov 21, 2022
Repository owner moved this from Todo to Done in 2.3.0 release Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant