Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tables): refactor legacy table to table composable #684

Merged
merged 8 commits into from
Nov 30, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Nov 18, 2022

Partially solved #595 (The last refactoring piece was included in #584)
Fixed #685
Fixes #679

The following tables are refactored to use TableComposable.

  • Event Template
    • Use TableComposable
    • Route states passed to create-recording form is added back with props compatible with this refactoring.
  • Event Type
    • Use TableComposable
    • Use non-compact pagination to allow setting current page
    • Reset currentPage to 1 (first page) if filter text is specified.
    • Allow multiple expanded rows.
      • Use hashcode of eventType.typeId to check if a event type row is expanded.
      • Use array of expandeds to keep track of expanded rows.
    • Moved EventType interface to Api.service.txs (avoid duplicate type definition).
  • Agent Template (fix included in fix(agent): action menu should have flip enabled #584 to also have custom action menu)
    • Use TableComposable
  • Agent Probe
    • Use TableComposable
  • Automatic Rules
    • Use TableComposable
    • Remove unnecessary rule refresh after closing upload modal.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Nov 18, 2022
@tthvo tthvo marked this pull request as ready for review November 21, 2022 21:02
@tthvo
Copy link
Member Author

tthvo commented Nov 21, 2022

Reset currentPage to 1 (first page) if filter text is specified.

I think this is the easiest and simpliest way to fix #685. But any better options?

@tthvo tthvo marked this pull request as draft November 23, 2022 19:43
@tthvo
Copy link
Member Author

tthvo commented Nov 23, 2022

Marked as draft again to refactor missing Automatic Rule table.

@tthvo tthvo marked this pull request as ready for review November 23, 2022 22:13
@tthvo
Copy link
Member Author

tthvo commented Nov 23, 2022

Addressed some new tasks. Ready for review again.

@maxcao13
Copy link
Member

Reset currentPage to 1 (first page) if filter text is specified.

I think this is the easiest and simpliest way to fix #685. But any better options?

No, it makes the most sense.

Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewazores andrewazores merged commit bb50b4c into cryostatio:main Nov 30, 2022
@tthvo tthvo deleted the table-refactor branch November 30, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
3 participants