-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tables): refactor legacy table to table composable #684
Conversation
69077d2
to
89ef5bc
Compare
I think this is the easiest and simpliest way to fix #685. But any better options? |
20f3688
to
7349675
Compare
Marked as draft again to refactor missing Automatic Rule table. |
Addressed some new tasks. Ready for review again. |
No, it makes the most sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bca6ca9
to
efb674f
Compare
Partially solved #595 (The last refactoring piece was included in #584)
Fixed #685
Fixes #679
The following tables are refactored to use
TableComposable
.eventType.typeId
to check if a event type row is expanded.EventType
interface toApi.service.txs
(avoid duplicate type definition).