-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event-templates): should update template selection when template list updates #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test image available:
|
tthvo
changed the title
fix(rules): should update template selection when template list updates
fix(event-templates): should update template selection when template list updates
May 1, 2023
Test image available:
|
Test image available:
|
Ready to review! This ensures the event template selection is synced with template list. However, there is an issue with AA config setting since it saves to local storage. This will be addressed in #1006 (might need a new UI design to separate display from setting form). |
Test image available:
|
andrewazores
approved these changes
May 2, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1002
Description of the change:
Whenever the template list changes, check with current template selection. If contained, do nothing. Otherwise, remove the selection.
Also, move
TargetSelect
andSelectTemplateSelectorForm
to@app/Shared
since they are pretty by themselves in their directory.Motivation for the change:
See #1002
How to manually test:
CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...