fix(settings): set unmountOnExit behaviour for setting groups #1004
Conversation
|
Test image available: |
|
In both Firefox and Chrome this change seems to just break the Settings view for me:
Every tab selection is just empty. The DOM elements are there, but they have css
If I use the inspector to remove that css property then it's fine.
|
|
Ohh thanks that should not be there. Interesting that it was working for me with that css in place (maybe I was messing around with browser inspector at the time). |
tthvo
force-pushed
the
settings
branch
2 times, most recently
from
d5ca360 to
b1b4fd4
Compare
|
Test image available: |
|
CI checks seem to be stuck due to a GH infra problem earlier in the day. I can't cancel the queued jobs nor restart them. Seems like the best thing is to wait for another PR like #1008 to go in first, then rebase this and allow that to trigger the CI to run again. |
|
Test image available: |
|
Test image available: |
(cherry picked from commit ed1f37c)
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to #793
Description of the change:
Unmount setting tab content that is not selected. This helps avoid situation where AA configurations cause the Auth modal to appear when first visiting
/settings(users might wonder why this opens as they don't see the AA config). This also allows faster load as React only needs to build 1 tab content at a time.Extend the min height for local target select to show more targets (currently it looks like, without scrolling, there is a single target).
Motivation for the change:
AA configurations causes the setting page to show Auth modal even if the AA configuration is not visible (i.e. Dashboard tab not selected).