fix(topology): correct toolbar mode icon #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
andrewazores
reviewed
May 8, 2023
It's too late for backporting non-critical fixes like this to 2.3.0, so this will have to wait for 2.4.0 or a 2.3.1 if we have to do one. |
|
Test image available: |
Make sense thanks! |
|
Test image available: |
andrewazores
approved these changes
May 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2023
* fix(topology): correct toolbar mode icon * chore(topology): localize mode icon label (cherry picked from commit 0213921)
andrewazores
pushed a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to #891
Description of the change:
Just switching the order of the toggle icon. The Graph View should show ListView icon, vice versa.
I am not sure we still have time for back-porting and its not very severe (just a little odd for users upgrading from 2.3 -> 2.4).
Motivation for the change:
To match OpenShift layout.
Screenshots