Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): run testing jobs in parallel #1029

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented May 10, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1017

Description of the change:

  • Split test ci steps into jobs that can be run in parallel.
  • Remove yarn build:notests as a step since we don't need to build the asset for any tests.
  • Set node version to 16.18.x (cryostat builds use node 16.18.1).

Motivation for the change:

See #1017

Screenshots

Screenshot from 2023-05-10 05-42-30

@tthvo tthvo added chore Refactor, rename, cleanup, etc. ci safe-to-test labels May 10, 2023
@tthvo tthvo requested review from andrewazores and maxcao13 May 10, 2023 09:45
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1029-a5220b9f8106b0b9bad71ebf16d39bd520cdfb96 sh smoketest.sh

Signed-off-by: Thuan Vo <thvo@redhat.com>
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1029-36cf1260995aa42e98adc416982737cacd8b03a2 sh smoketest.sh

@tthvo
Copy link
Member Author

tthvo commented May 10, 2023

Hmm what is that old build (16.x) Expected — Waiting for status to be reportedsticking around?

@andrewazores
Copy link
Member

Oh, I think it's just because the name of the job changed, so I need to update the repo config since that specific name is set up as a required check for PR reviews.

@tthvo
Copy link
Member Author

tthvo commented May 10, 2023

Ohh thats new! Thanks!

@andrewazores
Copy link
Member

There we go, fixed.

@andrewazores andrewazores merged commit a114488 into cryostatio:main May 10, 2023
@tthvo tthvo deleted the ci branch May 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Parallelize CI tests for eslint, format, and jest tests
2 participants