-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): allow preview deployment on release branches #1047
Conversation
Test image available:
|
EDIT: As discussed, we wait for 2.4. |
Test image available:
|
@andrewazores should we try this for |
Test image available:
|
|
Sounds good! |
2.3.1 downstream is out and upstream will be following up quite soon, so I think we can get moving on this as your last act ( :'( ) @tthvo . I need my memory refreshed - I think all this needs is for the Mirage stuff to get backported into the |
Yes exactly! I already have the PR on upstream website on wait too: cryostatio/cryostatio.github.io#129 |
I think the required mirage backports would be:
Does that seem right? |
Yehh looks right! Those are the only changes to Mirage I can think of too. |
49b5eb7
to
8a9022d
Compare
(cherry picked from commit 7e2966a)
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Related to #1045
Description of the change:
This extends workflow to run on release branches.
Motivation for the change:
CI Runs
Deployment: https://tthvo-cryostat-web-cryostat-v24.surge.sh
Action: https://github.com/tthvo/cryostat-web/actions/runs/5182474577/jobs/9339300166