Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): allow preview deployment on release branches #1047

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 5, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to #1045

Description of the change:

This extends workflow to run on release branches.

Motivation for the change:

I think we'll want to have a CI setup and deployment for the latest release branch, cryostat-v2.4 in this case in anticipation of the next release which will also contain these Mirage changes, so that the upstream website can just link to or iframe a preview of the latest upstream release, rather than development snapshots

CI Runs

Deployment: https://tthvo-cryostat-web-cryostat-v24.surge.sh

Action: https://github.com/tthvo/cryostat-web/actions/runs/5182474577/jobs/9339300166

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1047-68dc683bd1e831fc739ae6f93861ce93b00edc97 sh smoketest.sh

@tthvo tthvo requested a review from andrewazores June 5, 2023 22:27
@tthvo
Copy link
Member Author

tthvo commented Jun 5, 2023

For 2.3 release, we need to backport these Preview CI changes so that it can build the preview deployment for use in cryostatio/cryostatio.github.io#129

EDIT: As discussed, we wait for 2.4.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1047-68dc683bd1e831fc739ae6f93861ce93b00edc97 sh smoketest.sh

@tthvo
Copy link
Member Author

tthvo commented Aug 14, 2023

@andrewazores should we try this for 2.3.1?

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1047-49b5eb79f9cf1c8b9c9f08b36e6ebacbe7a81a88 sh smoketest.sh

@andrewazores
Copy link
Member

@andrewazores should we try this for 2.3.1?

2.3.1 is missing the Mirage changes that would enable this, I think. I'd rather not merge those in now just before the 2.3.1 release, but we could merge it directly after that release is out since the next would be 2.4.0 (no 2.3.2).

@tthvo
Copy link
Member Author

tthvo commented Aug 15, 2023

Sounds good!

@andrewazores
Copy link
Member

2.3.1 downstream is out and upstream will be following up quite soon, so I think we can get moving on this as your last act ( :'( ) @tthvo . I need my memory refreshed - I think all this needs is for the Mirage stuff to get backported into the cryostat-v2.3 branch, then this merged into main and also backported to cryostat-v2.3, right? After that, the upstream website can point to the surge deployment of 2.3.1?

@tthvo
Copy link
Member Author

tthvo commented Aug 30, 2023

I need my memory refreshed - I think all this needs is for the Mirage stuff to get backported into the cryostat-v2.3 branch, then this merged into main and also backported to cryostat-v2.3, right? After that, the upstream website can point to the surge deployment of 2.3.1?

Yes exactly! I already have the PR on upstream website on wait too: cryostatio/cryostatio.github.io#129

@andrewazores
Copy link
Member

I think the required mirage backports would be:

Does that seem right?

@tthvo
Copy link
Member Author

tthvo commented Aug 30, 2023

Yehh looks right! Those are the only changes to Mirage I can think of too.

@andrewazores andrewazores merged commit 7e2966a into cryostatio:main Aug 31, 2023
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
andrewazores pushed a commit that referenced this pull request Aug 31, 2023
(cherry picked from commit 7e2966a)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the ci-release branch June 7, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants