Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topology): warning resolver should include adding ssl certs (backport #1048) #1052

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 6, 2023

This is an automatic backport of pull request #1048 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix(topology): warning resolver should include adding ssl certs

Signed-off-by: Thuan Vo <thvo@redhat.com>

* feat(topology): add warning icon next to JVM ID if empty

* fix(topology): fix wordings

---------

Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 0dd044c)
@mergify mergify bot assigned tthvo Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Hi @mergify[bot]! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1052-087e67a10834dfd2b9929e690e0bf3d9ccf086f4 sh smoketest.sh

@andrewazores andrewazores merged commit 99ea62d into cryostat-v2.3 Jun 6, 2023
@mergify mergify bot deleted the mergify/bp/cryostat-v2.3/pr-1048 branch June 6, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants