Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agent): use consistent notification field #1057

Merged
merged 1 commit into from
Jun 23, 2023
Merged

chore(agent): use consistent notification field #1057

merged 1 commit into from
Jun 23, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 22, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Depends on https://github.com/cryostatio/cryostat/pull/1563
Related to cryostatio/cryostat-core#239

Description of the change:

Update to use correct field from notifications.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Jun 22, 2023
@tthvo tthvo requested review from andrewazores and maxcao13 June 22, 2023 08:16
@github-actions
Copy link

This PR/issue depends on:

@mergify mergify bot added the safe-to-test label Jun 22, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1057-d9aea482f370d67c55c14379d2b86acb46f0c363 sh smoketest.sh

maxcao13
maxcao13 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the changes from the other 2 prs in -core and cryostat.

chore(agent): use consistent notification field
29a9629 
Signed-off-by: Thuan Vo <thvo@redhat.com>
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1057-29a96292b298dfca13e407f1284eef02eb25b512 sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1057-29a96292b298dfca13e407f1284eef02eb25b512 sh smoketest.sh

@andrewazores andrewazores merged commit 13db028 into cryostatio:main Jun 23, 2023
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@mergify
fix(agent): use consistent notification field (#1057)
62f7b1c 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 13db028)
@mergify mergify bot mentioned this pull request Jun 23, 2023
Merged
andrewazores pushed a commit that referenced this pull request Jun 23, 2023
@mergify
fix(agent): use consistent notification field (#1057) (#1058)
ef06db2 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 13db028)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the agent-template branch June 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. dependent safe-to-test
Projects
No open projects
2.3.1 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tthvo @andrewazores @maxcao13